Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"You're Fired" action is confusing #2392

Closed
jwrober opened this issue Sep 17, 2024 · 1 comment · Fixed by #2426
Closed

"You're Fired" action is confusing #2392

jwrober opened this issue Sep 17, 2024 · 1 comment · Fixed by #2426
Labels
enhancement New feature or request good first issue Good for newcomers gui This issue requires changes to the user interface

Comments

@jwrober
Copy link
Collaborator

jwrober commented Sep 17, 2024

Is your feature request related to a problem? Please describe.
We have a unit action called "You're Fired" that allows a player to disband a unit inside a city to recoup some shields. The term "You're Fired" is confusion.

Describe the solution you'd like
Replace with "Disband Unit" or something more clear.

Describe alternatives you've considered
None

Additional context
Came up on Discord: https://discord.com/channels/378908274113904641/912500712833974322/1285687494247055422
@jwrober jwrober added enhancement New feature or request good first issue Good for newcomers gui This issue requires changes to the user interface labels Sep 17, 2024
@lmoureaux
Copy link
Contributor

Freeciv renamed this, I think we should use the same name.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 28, 2024
@lmoureaux
Action names: You're Fired -> Disband Unit
768904a 
"You're Fired" was difficult to understand and was on a totally
different tone than other action names.

Closes longturn#2392.
@lmoureaux lmoureaux mentioned this issue Oct 28, 2024
Merged
jwrober pushed a commit that referenced this issue Oct 29, 2024
@lmoureaux @jwrober
Action names: You're Fired -> Disband Unit
ea4e231 
"You're Fired" was difficult to understand and was on a totally
different tone than other action names.

Closes #2392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Action names: You're Fired -> Disband Unit lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober