Action names: You're Fired -> Disband Unit #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"You're Fired" was difficult to understand and was on a totally different tone than other action names. Closes longturn#2392.
|
Does this change break the other LT rulesets? |
|
It shouldn't affect them at all -- they'll keep showing |
jwrober
reviewed
Oct 29, 2024
| // TRANS: _You're Fired (100% chance of success). | ||
| return N_("%sYou're Fired%s"); | ||
| // TRANS: _Disband Unit (100% chance of success). | ||
| return N_("%sDisband Unit%s"); |
There was a problem hiding this comment.
The reason I'm asking is this change to actions.cpp. So this won't effect rulesets that use alternate language? Do we need to keep both in the cpp file?
There was a problem hiding this comment.
I see, good call! This is used as a default when no action name is specified in the ruleset and to avoid saving the default names in the ruleset editor.
jwrober
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"You're Fired" was difficult to understand and was on a totally different tone than other action names.
Closes #2392.