Fix dynacast can't work after full reconnect #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 111a5ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
davidzhao
reviewed
Dec 15, 2023
| @@ -368,11 +368,8 @@ export class SignalClient { | |||
| this.onAnswer = undefined; | |||
| this.onLeave = undefined; | |||
| this.onLocalTrackPublished = undefined; | |||
| this.onLocalTrackUnpublished = undefined; | |||
There was a problem hiding this comment.
seems like we'd want to keep these for when it's really cleaning up. So I guess that's the challenge here.
I think resetting them might be ok, but we just need to hook them up to the new callbacks during reconnect? wdyt @lukasIO ?
There was a problem hiding this comment.
agree that we'd want to unset them at one point. Will take a look at how to hook them up during reconnect already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.