Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all client callbacks are set up after reconnect #966

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 15, 2023

closes #965, attempts to fix the same issue without compromising on the cleanup of the callbacks.

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: cc4cbec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 15, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 78.74 KB (+0.05% 🔺)
dist/livekit-client.umd.js 84.32 KB (+0.08% 🔺)

@lukasIO lukasIO requested a review from boks1971 December 15, 2023 10:35
Copy link
Contributor

@cnderrauber cnderrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukasIO lukasIO merged commit 0dc45b3 into main Dec 15, 2023
3 checks passed
@lukasIO lukasIO deleted the lukas/fix-client-callbacks branch December 15, 2023 10:39
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants