Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynacast can't work after full reconnect #965

Closed
wants to merge 1 commit into from
Closed

Fix dynacast can't work after full reconnect #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-mugs-relax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'livekit-client': patch
---

Fix dynacast can't work after full reconnect
3 changes: 0 additions & 3 deletions src/api/SignalClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,11 +368,8 @@ export class SignalClient {
this.onAnswer = undefined;
this.onLeave = undefined;
this.onLocalTrackPublished = undefined;
this.onLocalTrackUnpublished = undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we'd want to keep these for when it's really cleaning up. So I guess that's the challenge here.

I think resetting them might be ok, but we just need to hook them up to the new callbacks during reconnect? wdyt @lukasIO ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that we'd want to unset them at one point. Will take a look at how to hook them up during reconnect already

this.onNegotiateRequested = undefined;
this.onOffer = undefined;
this.onRemoteMuteChanged = undefined;
this.onSubscribedQualityUpdate = undefined;
this.onTokenRefresh = undefined;
this.onTrickle = undefined;
this.onClose = undefined;
Expand Down
Loading