Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Chrome and Chromium #23

Closed
wants to merge 3 commits into from
Closed

Split Chrome and Chromium #23

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2017

Related to #22

This was supposed to be easy, a simple split, however now travis says Chromium can't connect even though Chrome works fine with CHROME_BIN=chromium-browser. Logs are here

I'd be happy to investigate further, but I simply cannot reproduce the issue on my machine. Even forced on a VM. Suggestions are welcome.

LoveIsGrief added 2 commits April 16, 2017 18:10
Related to #22 Split Chrome and Chromium
Related to #22 Split Chrome and Chromium
@4kochi
Copy link
Collaborator

4kochi commented Apr 18, 2017

Can you please remove the following line in the .travis.yml and tray to build again:

- export CHROME_BIN=chromium-browser

Related to #22 Split Chrome and Chromium
@ghost
Copy link
Author

ghost commented Apr 18, 2017

Sadly, that didn't help. Now only Chromium is being recognized (as it should be), but still exiting with exit code 0 ☹️

@4kochi
Copy link
Collaborator

4kochi commented Apr 18, 2017

Very strange. I will have a look at other repos which use chromium. Maybe I can find the issue.

@ghost
Copy link
Author

ghost commented Apr 18, 2017

@4kochi I made a pullrequest on karma-runner/karma#2664 to print the stdout and stderr. You might find it useful.

@GreenGremlin
Copy link

It turns out the flaky test failures are fixed by always running Chrome/Chromium in headless mode on Travis.

I fixed it here: #27

@4kochi
Copy link
Collaborator

4kochi commented Mar 21, 2018

Fixed by #27

@4kochi 4kochi closed this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants