Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): Buffer stdout and stderr for output when errors occur #2664

Merged
merged 1 commit into from Apr 28, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2017

When it is determined that an error occured during the run of a launch
it's useful to have output from the process.
We just need to know what was going on in order to debug (if necessary)

Related to #2663 Complete browser log output when process isn't started

Example output for a failing browser:

lamb sauce1

Achieved with

# Be in the project's root folder
folder=/tmp/karma-test
scriptName=faulty-browser.bash
script=$folder/$scriptName
mkdir -p $folder
echo '#!/usr/bin/env bash

echo "Starting..."
sleep 1
>&2 echo "An error was encountered"

exit 1
' > $script

chmod u+x $script

export PATH=$folder:$PATH
export CHROME_BIN=$scriptName
grunt test:client

@ghost
Copy link
Author

ghost commented Apr 18, 2017

Hmm... it looks like travis ran with Build#4019 with a non-existent commit da3702b 😕 Not sure what's going on.

I'll add a dummy commit to retrigger travis...

When it is determined that an error occured during the run of a launch
it's useful to have output from the process.
We just need to know what was going on in order to debug (if necessary)

Related to #2663 Complete browser log output when process isn't started
@dignifiedquire dignifiedquire merged commit 14b6dfd into karma-runner:master Apr 28, 2017
@dignifiedquire
Copy link
Member

Thank you :octocat:

@ghost
Copy link
Author

ghost commented Apr 28, 2017

Thanks for merging 😃

@ghost ghost deleted the feature-karma-2663 branch April 28, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant