Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting Chromium out of Chrome and adding support for headless mode #27

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

GreenGremlin
Copy link

Chromium is resolved in this order:

  1. Puppeteer installed locally
  2. Puppeteer installed globally
  3. System installed Chromium

@GreenGremlin
Copy link
Author

It looks like Travis is currently failing for master :(

@GreenGremlin GreenGremlin force-pushed the chromium-browser branch 7 times, most recently from 86936e4 to 9f0ef0f Compare March 20, 2018 22:55
@GreenGremlin GreenGremlin changed the title Add support for chromium on all platforms, including Chromium via Puppeteer Splitting Chromium out of Chrome and adding support for preferHeadless Mar 20, 2018
@GreenGremlin
Copy link
Author

It turns out the fix for the flaky test failures is to always run Chrome/Chromium in headless mode.

@GreenGremlin GreenGremlin changed the title Splitting Chromium out of Chrome and adding support for preferHeadless Splitting Chromium out of Chrome and adding support for headless mode Mar 20, 2018
…sSetting `preferHeadless=true` for travis fixes flaky test failures.
@4kochi 4kochi self-assigned this Mar 21, 2018
Copy link
Collaborator

@4kochi 4kochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for your effort

@4kochi 4kochi merged commit 22250ef into litixsoft:master Mar 21, 2018
@4kochi
Copy link
Collaborator

4kochi commented Mar 22, 2018

Released in v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants