feat: initial implementation of microvm create #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
force-pushed
the
create_plan
branch
from
7beabb2 to
243de34
Compare
|
This PR is so big! Please, split it 😊 |
This change implements the initial microvm create flow. It includes the "create plane" and various other changes to make this work. Test coverage has dropped as a result and we'll follow up with additional tests. Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
create_plan
branch
from
243de34 to
b18bb71
Compare
|
This PR is so big! Please, split it 😊 |
Even GitHub Actions are telling me i've done a bad thing! |
|
This PR is so big! Please, split it 😊 |
Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
create_plan
branch
from
ca5a427 to
5ae8cad
Compare
|
This PR is so big! Please, split it 😊 |
richardcase
changed the title
yitsushi
reviewed
Oct 5, 2021
| // AllowMetadataReq indicates if the network interface allows metadata requests. | ||
| bool allow_metadata_req = 1; | ||
| bool allow_metadata_req = 3; | ||
| // GuestMAC allows the specifying of a specifi MAC address to use for the interface. If |
There was a problem hiding this comment.
Suggested change
| // GuestMAC allows the specifying of a specifi MAC address to use for the interface. If | |
| // GuestMAC allows the specifying of a specific MAC address to use for the interface. |
| // GuestDeviceName is the name of the network interface to create in the microvm. If this | ||
| // is not supplied than a device name will be assigned automatically | ||
| optional string guest_device_name = 3; | ||
| // not supplied a autogenerated MAC address will be used. |
There was a problem hiding this comment.
Suggested change
| // not supplied a autogenerated MAC address will be used. | |
| // If not supplied an auto-generated MAC address will be used. |
| @@ -14,7 +14,8 @@ type MicroVMRepository interface { | |||
| Delete(ctx context.Context, microvm *models.MicroVM) error | |||
| // Get will get the microvm spec with the given name/namespace. | |||
| Get(ctx context.Context, name, namespace string) (*models.MicroVM, error) | |||
| // GetAll will get a list of microvm details. | |||
| // GetAll will get a list of microvm details. If namespace is an empty string all | |||
| // details of microvms will be returned. | |||
| GetAll(ctx context.Context, namespace string) ([]*models.MicroVM, error) | |||
There was a problem hiding this comment.
I know it's already there, but wouldn't be List a better name for this functionality?
| // make it available via a mount point. | ||
| GetAndMount(ctx context.Context, input GetImageInput) ([]models.Mount, error) | ||
| PullAndMount(ctx context.Context, input *ImageMountSpec) ([]models.Mount, error) |
There was a problem hiding this comment.
If it has a separate Pull, maybe a Mount function can be useful. For example if we want to control the full workflow and call Pull, verify, and then Mount. With this, we can call Pull, verify, and PullAndMerge, which is fine if it's guaranteed it will be the same and does not try to pull and/or check if the remote has been change again
yitsushi
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change contains the initial implementation of microvm create.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #31
Fixes #71
Fixes: #96
Special notes for your reviewer:
Checklist:
Release note: