Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots being unexpectedly deleted #96

Closed
richardcase opened this issue Sep 24, 2021 · 1 comment · Fixed by #98
Closed

Snapshots being unexpectedly deleted #96

richardcase opened this issue Sep 24, 2021 · 1 comment · Fixed by #98
Assignees
Labels
kind/bug Something isn't working

Comments

@richardcase
Copy link
Member

What happened:
When removing the containerd lease for a specific microvm (e.g. reignite/ns1/mvm0) to remove the snapshots etc for a specific microvm it is also removing the snapshots for other microvms:

image

What did you expect to happen:
I would expect it to only remove the snapshots for the microvm the lease is for (i.e. mvm0) and not other microvms (i.e. mvm1 in this example).

How to reproduce it:

  1. Create multiple microvms using reignite on the same host
  2. Run something like ctr -n reignite leases rm reignite/ns1/mvm0

Environment:

  • reignite version:
  • OS (e.g. from /etc/os-release):
@richardcase richardcase added the kind/bug Something isn't working label Sep 24, 2021
@richardcase richardcase self-assigned this Sep 29, 2021
@richardcase richardcase added this to the v0.1.0 milestone Sep 29, 2021
@richardcase
Copy link
Member Author

This was being caused by not creating the snapshots with a lease and so the garbage collector when it ran would delete the snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant