Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microvm repo check if spec is the same #71

Closed
richardcase opened this issue Aug 23, 2021 · 0 comments · Fixed by #98
Closed

Microvm repo check if spec is the same #71

richardcase opened this issue Aug 23, 2021 · 0 comments · Fixed by #98
Assignees
Labels
kind/bug Something isn't working

Comments

@richardcase
Copy link
Member

Describe the solution you'd like:
When saving the microvm spec in the repo we need to check if there is actually an update to the spec or not. If nothing has changed, then we don't need to take any action.

Why do you want this feature:

If we currently try saving where there is no update then an error is returned.

Anything else you would like to add:

Easiest way is to SHA256 hash the content and compare it to the digest of the content in the containerd content store.

@richardcase richardcase added kind/bug Something isn't working area/reignite labels Aug 23, 2021
@richardcase richardcase added this to the Milestone 1 - re:ignite milestone Aug 23, 2021
@richardcase richardcase self-assigned this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant