Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new peniko with color #742

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update to new peniko with color #742

merged 1 commit into from
Nov 28, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

This is a work in progress showing a version of Vello that is using the new color crate and the corresponding updated peniko. Both are git dependencies here (color being a transitive one).

There's plenty of stuff to do after the initial compilation, and a few things are still not working here like the code that needs PartialCmp for Color.

Once this is all working, we can look at getting rid of ColorF64 and more!

@waywardmonkeys waywardmonkeys added this to the Vello 0.4 Release milestone Nov 24, 2024
@waywardmonkeys waywardmonkeys mentioned this pull request Nov 24, 2024
Merged
@waywardmonkeys waywardmonkeys force-pushed the new-peniko-new-color branch 5 times, most recently from e73431f to 0726ffa Compare November 27, 2024 07:15
@waywardmonkeys waywardmonkeys mentioned this pull request Nov 28, 2024
Merged
@waywardmonkeys waywardmonkeys changed the title WIP: Converting to new peniko with color. Update to new peniko with color Nov 28, 2024
@waywardmonkeys waywardmonkeys marked this pull request as ready for review November 28, 2024 03:24
@waywardmonkeys waywardmonkeys mentioned this pull request Nov 28, 2024
Open
8 tasks
@waywardmonkeys
Copy link
Contributor Author

When reviewing this, keep in mind the list of things that is already in #749.

DJMcNab
DJMcNab approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not actually run this, but that's what tests are for 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
examples/headless/src/main.rs Show resolved Hide resolved
vello_tests/snapshots/many_clips.png Outdated Show resolved Hide resolved
vello_tests/tests/property.rs Show resolved Hide resolved
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 28, 2024
Merged via the queue into linebender:main with commit 9551ba7 Nov 28, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the new-peniko-new-color branch November 28, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.4 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab