-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use color
for color.
#63
Conversation
f165bcf
to
304ab8c
Compare
Some of these will be resolved in
|
0b9d293
to
63060d0
Compare
I've done more work here updating most of the gradient code, adding a feature to disable the legacy color code, and adding some more comments. There are some |
I think I will remove the legacy code instead, and export a type alias |
52da6e8
to
c65c325
Compare
(Just a note: with color becoming 32-bit per channel, maybe Lines 37 to 50 in d825bdf
|
ab4783e
to
117742c
Compare
e4a2477
to
0fef133
Compare
I did this in #65 as it let me simplify some of the MSRV issues. |
0fef133
to
c6ac1f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts on the changelog. 😈
a3cb839
to
0d5c2da
Compare
0d5c2da
to
09a5d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tried running the code with Vello or anything like that, but the code changes look fine to me.
@@ -77,7 +91,11 @@ impl Brush { | |||
/// This is useful for methods that would like to accept brushes by reference. Defining | |||
/// the type as `impl<Into<BrushRef>>` allows accepting types like `&LinearGradient` | |||
/// directly without cloning or allocating. | |||
#[derive(Copy, Clone, PartialEq, Debug)] | |||
#[cfg_attr( | |||
target_pointer_width = "32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
Color functionality is now provided by the `color` crate.
09a5d12
to
ab9f540
Compare
Color functionality is now provided by the
color
crate.