You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once #742 lands, there some stuff that we should fix up and improve and I don't want to keep expanding the scope of #742:
Remove ColorF64: A first pass wouldn't use the good gradient interpolation yet, just use DynamicColor instead.
This is complicated by the fact that gradients and non-gradient color data are being written in different byte orders. Remove ColorF64 #759
vello_encoding::RenderConfig::new doesn't need to take a reference to the base color, nor does it have to use peniko::Color.
Instead, it can perhaps use impl Into<DrawColor> and simplify calling code as that allows a variety of color types to be used.
This would probably not change a lot though since we don't want to use DrawColor in RenderParams from the main vello crate.
Switch more example code from using Color::from_* or Color::new to using colors from color::palette::css where the actual color doesn't really matter.
Notably, some of the examples should be able to entirely stop using peniko::Color.
DrawColor has a comment about the endianness, so when fixing things above, make sure that this is corrected.
This is correct after Update color byte packing #758
The text was updated successfully, but these errors were encountered:
Once #742 lands, there some stuff that we should fix up and improve and I don't want to keep expanding the scope of #742:
ColorF64
: A first pass wouldn't use the good gradient interpolation yet, just useDynamicColor
instead.This is complicated by the fact that gradients and non-gradient color data are being written in different byte orders.
Remove
ColorF64
#759Update color byte packing #758
vello_encoding::RenderConfig::new
doesn't need to take a reference to the base color, nor does it have to usepeniko::Color
.Instead, it can perhaps use
impl Into<DrawColor>
and simplify calling code as that allows a variety of color types to be used.This would probably not change a lot though since we don't want to use
DrawColor
inRenderParams
from the mainvello
crate.Color::from_*
orColor::new
to using colors fromcolor::palette::css
where the actual color doesn't really matter.Notably, some of the examples should be able to entirely stop using
peniko::Color
.parse_color
has some fallback forrgb(...)
syntax that is probably not needed anymore.pico_svg: Simplify color parsing. #753
to_u32
methods incolor
to beto_be_u32
andto_le_u32
or some other naming and making it more clear up through the stack.(Premul)Rgba8::to_u32
now returns in little endian format. color#77DrawColor
has a comment about the endianness, so when fixing things above, make sure that this is corrected.This is correct after Update color byte packing #758
The text was updated successfully, but these errors were encountered: