Update color byte packing #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colors are now packed in little-endian u32s rather than big-endian which lets us get rid of some swizzling within the shaders. We also get to take advantage of the new `to_u8_array` functions to simplify the image creation for some tests.
8 tasks
raphlinus
approved these changes
Dec 1, 2024
|
If anything breaks, then it'll just be another step towards having consistent color byte encoding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colors are now packed in little-endian u32s rather than big-endian which lets us get rid of some swizzling within the shaders.
We also get to take advantage of the new
to_u8_arrayfunctions to simplify the image creation for some tests.