Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ColorF64 #759

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove ColorF64 #759

merged 1 commit into from
Dec 2, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This is a step towards using color for the gradients, first moving to use the lerp function in AlphaColor and getting rid of ColorF64 since our colors are now f32-based.

@waywardmonkeys
Remove ColorF64
b3fa53e 
This is a step towards using `color` for the gradients, first
moving to use the `lerp` function in `AlphaColor` and getting
rid of `ColorF64` since our colors are now `f32`-based.
@waywardmonkeys waywardmonkeys mentioned this pull request Dec 1, 2024
Open
8 tasks
raphlinus
raphlinus approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

I'm a bit curious about the snapshot changes. They're 1 lsb changes, due to roundoff? I guess it's unrealistic to expect them to be bit identical.

@waywardmonkeys
Copy link
Contributor Author

It was a very small change, just above the permitted deviation.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 2, 2024
Merged via the queue into linebender:main with commit 68b3ce2 Dec 2, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-colorf64 branch December 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @raphlinus