kvdb: remove etcd test fixture cleanup calls #7352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the cleanup calls which no longer exist since `t.Cleanup` is now called from within `NewEtcdTestFixture`
ellemouton
force-pushed
the
removeEtcdCleanups
branch
from
6ae3ee8 to
2b4de46
Compare
|
Changes look good to me. Though to avoid needing to merge and then tag another version, should we include the |
|
good catch! adding |
Oops, looks like Joost was faster: #7353 |
guggero
approved these changes
Jan 24, 2023
bhandras
approved these changes
Jan 24, 2023
Yes, unfortunately that will only be fixed once we bump the version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the cleanup calls which no longer exist since
t.Cleanupis now called from withinNewEtcdTestFixture.Accidentally had this in the second sqlite PR instead of in the first
kvdbone 🙈 my bad