Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvdb: remove etcd test fixture cleanup calls #7352

Merged
merged 1 commit into from
Jan 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
kvdb+docs: remove etcd test fixture cleanup calls
Remove the cleanup calls which no longer exist since `t.Cleanup` is now
called from within `NewEtcdTestFixture`
  • Loading branch information
ellemouton committed Jan 24, 2023
commit 2b4de46c72ffd6ee164bd9c77a6cd7059827d7ce
3 changes: 3 additions & 0 deletions docs/release-notes/release-notes-0.16.0.md
Original file line number Diff line number Diff line change
@@ -228,6 +228,9 @@ data.
* [Add Custom Message to the fuzz testsuite
in the lnwire package](https://github.com/lightningnetwork/lnd/pull/7303)

* [Remove non-existent Cleanup calls from etcd test code in the `kvdb`
package](https://github.com/lightningnetwork/lnd/pull/7352)

## `lncli`

* [Add an `insecure` flag to skip tls auth as well as a `metadata` string slice
1 change: 0 additions & 1 deletion kvdb/etcd/db_test.go
Original file line number Diff line number Diff line change
@@ -81,7 +81,6 @@ func TestNewEtcdClient(t *testing.T) {
t.Parallel()

f := NewEtcdTestFixture(t)
defer f.Cleanup()

client, ctx, cancel, err := NewEtcdClient(
context.Background(), f.BackendConfig(),
1 change: 0 additions & 1 deletion kvdb/etcd_test.go
Original file line number Diff line number Diff line change
@@ -158,7 +158,6 @@ func TestEtcd(t *testing.T) {
t.Parallel()

f := etcd.NewEtcdTestFixture(t)
defer f.Cleanup()

test.test(t, f.NewBackend(doRwLock))