Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: bump etcd to v3.5.7 #7280

Closed
wants to merge 1 commit into from

Conversation

joostjager
Copy link
Contributor

@guggero
Copy link
Collaborator

guggero commented Jan 3, 2023

Looks like this version of etcd doesn't compile on darwin amd64:

 Error: ../../../../go/pkg/mod/go.etcd.io/etcd/server/[email protected]/wal/wal.go:119:34: not enough arguments in call to fileutil.CreateDirAll
	have (string)
	want (*zap.Logger, string)

@joostjager
Copy link
Contributor Author

Bumped to the next version 3.5.7 to see if that's better.

@guggero
Copy link
Collaborator

guggero commented Jan 24, 2023

Doesn't seem to be the case. Do we need to create an issue in their repo? Sounds like something small.

EDIT: I think it's because we don't use the latest server version as well.
This replace fixed it for me:

replace go.etcd.io/etcd/server/v3 => go.etcd.io/etcd/server/v3 v3.5.7

@guggero
Copy link
Collaborator

guggero commented Jan 24, 2023

Also, I think to avoid needing the replace, we instead should bump the dependencies correctly in the kvdb/go.mod file, merge, tag and then it will be bumped in the main mod file automatically when we go to the next kvdb tagged version.

@joostjager joostjager changed the title mod: bump etcd to v3.5.6 mod: bump etcd to v3.5.7 Jan 24, 2023
@joostjager
Copy link
Contributor Author

Created first step here: #7353

@guggero guggero linked an issue Jan 24, 2023 that may be closed by this pull request
@@ -142,7 +143,7 @@ func (db *DB) Init(ctx context.Context, dbPath string) error {
db.Etcd = cfg

case db.Backend == PostgresBackend:
postgres.Init(db.Postgres.MaxConnections)
sqlbase.Init(db.Postgres.MaxConnections)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellemouton not sure if I am supposed to bump kvdb here before merge of #7252 ?

@joostjager
Copy link
Contributor Author

@ellemouton fixed the final bump in 2fd4f3f, closing.

@joostjager joostjager closed this Feb 6, 2023
@saubyk saubyk removed this from the v0.17.1 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants