-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod: bump etcd to v3.5.7 #7280
mod: bump etcd to v3.5.7 #7280
Conversation
Looks like this version of
|
Bumped to the next version 3.5.7 to see if that's better. |
Doesn't seem to be the case. Do we need to create an issue in their repo? Sounds like something small. EDIT: I think it's because we don't use the latest server version as well.
|
Also, I think to avoid needing the replace, we instead should bump the dependencies correctly in the |
Created first step here: #7353 |
@@ -142,7 +143,7 @@ func (db *DB) Init(ctx context.Context, dbPath string) error { | |||
db.Etcd = cfg | |||
|
|||
case db.Backend == PostgresBackend: | |||
postgres.Init(db.Postgres.MaxConnections) | |||
sqlbase.Init(db.Postgres.MaxConnections) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellemouton not sure if I am supposed to bump kvdb here before merge of #7252 ?
@ellemouton fixed the final bump in 2fd4f3f, closing. |
Fix etcd-io/etcd#14268