Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD integration package is broken if any other module in the project uses updated opentelemetry #14268

Closed
rsafonseca opened this issue Jul 24, 2022 · 4 comments

Comments

@rsafonseca
Copy link

rsafonseca commented Jul 24, 2022

Currently it's not possible to use the go.etcd.io/etcd/tests/v3/integration module, in any version of 3.5 if another module in the project uses an updated version of OpenTelemetry.
Trying to run "go mod tidy" in a project that uses the ETCD integration package along with another module that uses an updated version of OpenTelemetry results in the following:

go.etcd.io/etcd/tests/v3/integration imports
go.etcd.io/etcd/server/v3/embed imports
go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.8.0), but does not contain package go.opentelemetry.io/otel/semconv

To resolve this, ETCD 3.5 branch should either be updated to use OpenTelemetry 1.x as has been done on 3.6.0 alpha, to allow this to be used along with other updated modules.

@rsafonseca
Copy link
Author

Related issues: open-telemetry/opentelemetry-go#2577
#13664

@serathius
Copy link
Member

Please try ./scripts/updatedep.sh

@rcrowe
Copy link

rcrowe commented Aug 12, 2022

Looks like #14311 has resolved this issue?

A replace unblocked me...

replace (
	go.etcd.io/etcd/api/v3 v3.5.4 => go.etcd.io/etcd/api/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/client/pkg/v3 v3.5.4 => go.etcd.io/etcd/client/pkg/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/client/v3 v3.5.4 => go.etcd.io/etcd/client/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/etcdctl/v3 v3.5.4 => go.etcd.io/etcd/etcdctl/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/pkg/v3 v3.5.4 => go.etcd.io/etcd/pkg/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/raft/v3 v3.5.4 => go.etcd.io/etcd/raft/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/server/v3 v3.5.4 => go.etcd.io/etcd/server/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/tests/v3 v3.5.4 => go.etcd.io/etcd/tests/v3 v3.5.5-0.20220808200321-9e95685d0a6d
	go.etcd.io/etcd/v3 v3.5.4 => go.etcd.io/etcd/v3 v3.5.5-0.20220808200321-9e95685d0a6d
)

@ahrtr
Copy link
Member

ahrtr commented Aug 22, 2022

Yes, this issue has already been resolved in release-3.5, and it will be included in 3.5.5. The workaround for now (before the release of 3.5.5) would be using replace directive just as @rcrowe pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants