Allow adding prologue to noise connections #1663
Conversation
| return newSecureSession(i.t, ctx, insecure, p, i.prologue, true) | ||
| } | ||
|
|
||
| func (t *Transport) WithNoiseOptions(opts NoiseOptions) sec.SecureTransport { |
There was a problem hiding this comment.
Why can't this be a normal constructor option?
There was a problem hiding this comment.
This is because the noise transport has both transport level and session level options. eg. The private key could be shared among multiple different connections, but the prologue can be unique to each connection.
There was a problem hiding this comment.
I can rename this to WithSessionOptions
| manet "github.com/multiformats/go-multiaddr/net" | ||
| ) | ||
|
|
||
| type NoiseOptions struct { |
There was a problem hiding this comment.
Please avoid config structs and use the normal config function pattern.
There was a problem hiding this comment.
I considered that but want to avoid exposing the intermediate transport.
p2p/security/noise/transport_test.go
Outdated
| go func() { | ||
| defer close(done) | ||
| tpt, err := initTransport. | ||
| WithSessionOptions(Prologue([]byte("testtesttest"))) |
There was a problem hiding this comment.
Nit: no line break.
Your choice of this prologue doesn't make this easy to read.
|
@marten-seemann It looks like the previous commit failed the tests because |
|
Yeah, that's a known flaky test. |
Allows adding the prologue to an existing noise transport. This is for potential use in implementing the webrtc transport.
Related discussion: libp2p/specs#412 (comment)