-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webrtc/: Add libp2p WebRTC browser-to-server spec #412
Conversation
Co-authored-by: Marten Seemann <[email protected]>
No objections from my end. |
Co-authored-by: Thomas Eizinger <[email protected]>
Friendly ping @marten-seemann. Does this look good to you? |
I understand that you're being over cautious with clicking the merge button, but can we now consider that this version of the spec is "final", in the sense that the logic isn't going to change before merging, and the only things that could change are possible clarifications of the language? |
Quite a long journey. 475 (+1) comments and 135 commits, 14 reviewers, ... I am merging here as a Working Draft. We can promote it once we have a released implementation. A couple of shoutouts:
Up next: browser-to-browser use-case. |
Shoutout to me for having started the whole thing before it was aggressively taken over and not receiving a shoutout |
Let's wait a bit to see if there's an answer [to this comment](libp2p/specs#412 (comment)) before merging this.
Hey 👋 This is a WebRTC transport implemented in accordance w/ the [spec](libp2p/specs#412). It's based on the [webrtc-rs](https://github.com/webrtc-rs/webrtc) library. Resolves: #1066.
I am working a project that heavily relies on the libp2p-js impl. I am currently working towards enabling a huge amount of dapps that benefit greatly from WebRTC. What I am missing (?) currently is a way for having js WebRTC listeners. Now it seems to only be supported/to-be-supported for the the Go and Rust impl. Correct me if I have understood the spec. incorrectly, but is this something that is planned for? Or not? |
Follow #497 |
With libp2p#412 and libp2p#497 merged, this roadmap item can be moved to "done".
With #412 and #497 merged, this roadmap item can be moved to "done". Co-authored-by: Prithvi Shahi <[email protected]>
This pull requests summarizes the status quo of the ongoing WebRTC in libp2p work. In other words, it represents the summary of all past discussions like #220.
While describing both the browser-to-server and browser-to-browser use-case, priority is on the former. Once the browser-to-server use-case is sufficiently specified, I will remove the browser-to-browser use-case, merge this pull request, and start iteration two, namely to sufficiently specify the browser-to-browser use-case.
Remaining work items for browser-to-server:
RTCDataChannel
ID negotiation webrtc/: Add libp2p WebRTC browser-to-server spec #412 (comment)RTCDataChannel
ID reuse webrtc/: Add libp2p WebRTC browser-to-server spec #412 (comment)RTCConnection.createDataChannel
. https://github.com/libp2p/specs/pull/412/files#r995877508