This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Length prefixed protobuf messages #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
| const msgbuf = pb.Message.toBinary({message: buf.subarray()}); | ||
| const sendbuf = lp.encode.single(msgbuf) | ||
| log.trace(`[stream:${this.id}][${this.stat.direction}] sending message: length: ${res.length} ${res}, encoded through pb as ${msgbuf}`); | ||
| this.channel.send(sendbuf.subarray()) |
There was a problem hiding this comment.
More of a question, but why do you have to call subarray all the time? Is it to switch type somehow?
There was a problem hiding this comment.
The Uint8ArrayList can have a single message spread across multiple different Uint8Array instances. Calling subarray makes them readable as a single Uint8Array which is much easier to work with.
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
GlenDC
reviewed
Oct 31, 2022
John-LittleBearLabs
approved these changes
Nov 1, 2022
|
@ckousik does this resolve the compatibility issues you were seeing with libp2p/rust-libp2p#2622? |
yes |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add length prefix to protobuf messages.