Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transports/noise: Expose Prologue mechanism #2791

Closed
mxinden opened this issue Aug 2, 2022 · 3 comments · Fixed by #2903
Closed

transports/noise: Expose Prologue mechanism #2791

mxinden opened this issue Aug 2, 2022 · 3 comments · Fixed by #2903

Comments

@mxinden
Copy link
Member

mxinden commented Aug 2, 2022

Description

Enable users to provide a Noise Prologue via Builder::prologue.

Motivation

Needed for #2622, more specifically to validate the remote's TLS fingerprints. See libp2p/specs#412 (comment).

Requirements

Open questions

Are you planning to do it yourself in a pull request?

Maybe. In case someone wants to pick this up instead, please comment to make sure we are not duplicating work.

@mxinden
Copy link
Member Author

mxinden commented Aug 2, 2022

Corresponding pull request on the Golang side: libp2p/go-libp2p#1663

@mxinden mxinden mentioned this issue Sep 6, 2022
4 tasks
@thomaseizinger
Copy link
Contributor

@melekes Let me know if you are going to pick this up, otherwise I'll take it :)

@melekes
Copy link
Contributor

melekes commented Sep 12, 2022

Please go ahead. I will focus more on smoldot / substrate side for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants