Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sf4 fix #331

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Sf4 fix #331

merged 3 commits into from
Dec 17, 2018

Conversation

rjwebdev
Copy link
Contributor

@rjwebdev rjwebdev commented Sep 19, 2018

Since Symfony 4, a new directory structured is been used.

With this commit, the new translations directory in the project root dir will also be included in the directories where the bundle will look for translations. All translations files under the 'translations' directory will be included.

@vizo
Copy link

vizo commented Sep 25, 2018

Please merge, thanks.

@rjwebdev
Copy link
Contributor Author

rjwebdev commented Oct 3, 2018

@Spike31,

Could you please provide feedback to this pull request?

Thanks!

@rjwebdev
Copy link
Contributor Author

@Spike31 ,

Is it possible to check this pull request and merge it? Thx!

@MConrotte
Copy link

MConrotte commented Dec 17, 2018 via email

@gilles-g gilles-g merged commit 91d1844 into lexik:master Dec 17, 2018
@gilles-g
Copy link
Member

Done! :)

@rjwebdev
Copy link
Contributor Author

@Spike31 ,

Thx! Do you have any idea when the next version will be released?

@gilles-g
Copy link
Member

@rjwebdev It's already available

@rjwebdev rjwebdev deleted the sf4-fix branch December 20, 2018 08:54
WL-arek pushed a commit to wlogic/LexikTranslationBundle that referenced this pull request Mar 29, 2021
* lexik/3.4:
  Fix travis for 3.4 (lexik#376)
  Add Symfony 4.3 kernel.locale_aware tag (lexik#347)
  Sf4 fix (lexik#331)
  Update LexikTranslationBundle.es.yml (lexik#339)
  class names are declared in StudlyCaps (lexik#328)
  🐛 Fix render twig in controller for overriding purpose (lexik#311)
  Fix BC with Symfony 2.8 LTS (lexik#322)
  add sf4 support (lexik#320)
  Added modified flag in order to fix merge algorithm (lexik#261)
  Remove useless check on http method (lexik#315)
  Corrected ExportTranslationsCommand service id. (lexik#314)
  Fix symfony >= 3.4 user deprecated. (lexik#310)
  lexik#306. set public of 'translate' alias for compatibility with other components in SF4. (lexik#309)
  Symfony 4 support (lexik#305)
  Minor typo fixes (lexik#296)
  Replace Propel to Propel2. (lexik#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants