Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexik don't load Symfony4 translations #333

Open
info-droid opened this issue Sep 20, 2018 · 4 comments · Fixed by #354
Open

Lexik don't load Symfony4 translations #333

info-droid opened this issue Sep 20, 2018 · 4 comments · Fixed by #354

Comments

@info-droid
Copy link

Hi,

In DependencyInjection/LexikTranslationExtension.php, you never try to find translation files in framework.translator.default_path.

So you don't find translations from new /translations/ Symfony 4 directory.

I've missed something, or it's normal ?

@rjwebdev
Copy link
Contributor

I already created a pull request for this problem:
#331

@Seb33300
Copy link
Contributor

Seb33300 commented Jan 10, 2019

Your pull request doesn't use framework.translator.default_path option.

So if the option value is modified, this bundle will not work.

@shengjie
Copy link

Hello , symfony 3.4 also supports loading translations in translations/ folder,

see https://symfony.com/doc/3.4/translation.html#translation-resource-file-names-and-locations

@fsoedjede
Copy link

Hello!
@rjwebdev the pull request your made only handle SF4+ but as @shengjie quote it, in 3.4 we can have the new structure so your fix doesn't work if we are using 3.4.
I've created this PR #354

bartmcleod added a commit that referenced this issue May 3, 2021
…-path

Fix translator dirs by relying on `translator.default_path` #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants