Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC with Symfony 2.8 LTS #322

Merged
merged 2 commits into from
May 18, 2018

Conversation

SanderVerkuil
Copy link
Contributor

@SanderVerkuil SanderVerkuil commented May 12, 2018

The parameter %kernel.project_dir% is not existent in symfony versions prior to version 3.3. This fix checks whether the parameter %kernel.project_dir% exists, otherwise it will use the %kernel.root_dir%/../ as an alternative.

Fixes #321

Copy link

@zzenmate zzenmate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be approved, I also have a problem with last version LexikTranslationBundle.

@gilles-g gilles-g self-requested a review May 15, 2018 13:20
@gilles-g gilles-g self-assigned this May 15, 2018
@gilles-g
Copy link
Member

Ok let's go!

@gilles-g gilles-g merged commit 2657f57 into lexik:master May 18, 2018
@gilles-g
Copy link
Member

@SanderVerkuil SanderVerkuil deleted the backwards_compatible/symfony_2_8 branch November 1, 2018 15:26
WL-arek pushed a commit to wlogic/LexikTranslationBundle that referenced this pull request Mar 29, 2021
* lexik/3.4:
  Fix travis for 3.4 (lexik#376)
  Add Symfony 4.3 kernel.locale_aware tag (lexik#347)
  Sf4 fix (lexik#331)
  Update LexikTranslationBundle.es.yml (lexik#339)
  class names are declared in StudlyCaps (lexik#328)
  🐛 Fix render twig in controller for overriding purpose (lexik#311)
  Fix BC with Symfony 2.8 LTS (lexik#322)
  add sf4 support (lexik#320)
  Added modified flag in order to fix merge algorithm (lexik#261)
  Remove useless check on http method (lexik#315)
  Corrected ExportTranslationsCommand service id. (lexik#314)
  Fix symfony >= 3.4 user deprecated. (lexik#310)
  lexik#306. set public of 'translate' alias for compatibility with other components in SF4. (lexik#309)
  Symfony 4 support (lexik#305)
  Minor typo fixes (lexik#296)
  Replace Propel to Propel2. (lexik#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You have requested a non-existent parameter "kernel.project_dir"
3 participants