Finish migration from int64 durations to durationpb #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgporada
changed the title
aarongable
previously approved these changes
Nov 27, 2023
aarongable
approved these changes
Nov 28, 2023
beautifulentropy
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR finishing the migration from int64 durations to protobuf
*durationpb.Durationby removing all usage of the old int64 fields. In the previous PR #7146 all fields were switched to read from the protobuf durationpb fields.Fixes #7097
DO NOT MERGE UNTIL #7146 IS DEPLOYED TO STAGING/PRODUCTION.