Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace int64 durations with durationpb in proto files #7097

Closed
pgporada opened this issue Sep 22, 2023 · 0 comments · Fixed by #7147
Closed

Replace int64 durations with durationpb in proto files #7097

pgporada opened this issue Sep 22, 2023 · 0 comments · Fixed by #7147
Assignees
@pgporada
Milestone
Sprint 2023-11-14

Comments

@pgporada
Copy link
Member

pgporada commented Sep 22, 2023 •
edited
Loading

Related to #7060

There are int64's masquerading as time.Durations in protobuf files. We can replace those with durationpb instead and do some nice cleanup.

Example of an int64 that could be a durationpb

boulder/sa/proto/sa.proto

Line 180 in 574c5cf

int64 window = 1;

which is used at

boulder/sa/saro.go

Line 522 in 7b3e8df

ssa.clk.Now().Add(-time.Duration(req.Window)),

In that instance, req.Window could be no different than 1 * time.Hour.
@aarongable aarongable mentioned this issue Sep 26, 2023
Merged
@aarongable aarongable added this to the Sprint 2023-10-10 milestone Oct 10, 2023
@pgporada pgporada mentioned this issue Oct 12, 2023
Merged
pgporada added a commit that referenced this issue Oct 26, 2023
@pgporada
Rename protobuf duration fields to <fieldname>NS and populate new dur…
b8b1054 
…ation fields (#7115)

* Renames all of int64 as a time.Duration fields to `<fieldname>NS` to
indicate they are Unix nanoseconds.
* Adds new `google.protobuf.Duration` fields to each .proto file where
we previously had been using an int64 field to populate a time.Duration.
* Updates relevant gRPC messages.

Part 1 of 3 for #7097
This was referenced Nov 8, 2023
Merged
Merged
pgporada added a commit that referenced this issue Nov 13, 2023
@pgporada
Read from durationpb instead of int64 durations (#7146)
279a4d5 
Switch to reading grpc duration values from the new durationpb protofbuf
fields, completely ignoring the old int64 fields.

Part 2 of 3 for #7097
pgporada added a commit that referenced this issue Nov 28, 2023
@pgporada
Finish migration from int64 durations to durationpb (#7147)
51e9f39 
This is a cleanup PR finishing the migration from int64 durations to
protobuf `*durationpb.Duration` by removing all usage of the old int64
fields. In the previous PR
#7146 all fields were
switched to read from the protobuf durationpb fields.

Fixes #7097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgporada pgporada

Labels
None yet
Projects
None yet
Milestone
Sprint 2023-11-14
Development

Successfully merging a pull request may close this issue.

Finish migration from int64 durations to durationpb letsencrypt/boulder
2 participants
@pgporada @aarongable