Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish migration from int64 durations to durationpb #7147

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Finish migration from int64 durations to durationpb #7147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5daf83f
Read from durationpb instead of int64 durations
pgporada Nov 8, 2023
83bd0c8
Finish migration from int64 durations to durationpb
pgporada Nov 8, 2023
55b3ea9
Check durationpb for nil or zero value
pgporada Nov 9, 2023
e44a01a
Merge branch 'read-from-durationpb' into cleanup-old-int64-durations
pgporada Nov 9, 2023
01155cd
Check another req.Window for nil or zero
pgporada Nov 9, 2023
bfafd21
Merge branch 'read-from-durationpb' into cleanup-old-int64-durations
pgporada Nov 9, 2023
322fb80
Merge branch 'main' into read-from-durationpb
pgporada Nov 9, 2023
d353ae8
Merge branch 'read-from-durationpb' into cleanup-old-int64-durations
pgporada Nov 9, 2023
8f7bf37
Merge branch 'main' into cleanup-old-int64-durations
pgporada Nov 27, 2023
01194ad
Merge branch 'main' into cleanup-old-int64-durations
pgporada Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ra/ra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,9 +1496,8 @@ func (ra *RegistrationAuthorityImpl) checkCertificatesPerFQDNSetLimit(ctx contex
}

prevIssuances, err := ra.SA.FQDNSetTimestampsForWindow(ctx, &sapb.CountFQDNSetsRequest{
Domains: names,
WindowNS: limit.Window.Duration.Nanoseconds(),
Window: durationpb.New(limit.Window.Duration),
Domains: names,
Window: durationpb.New(limit.Window.Duration),
})
if err != nil {
return fmt.Errorf("checking duplicate certificate limit for %q: %s", names, err)
Expand Down
Loading