Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command palette arrangement, and responsive design #4446

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Feb 22, 2024

Summary

Description of the change(s) you made

Rearrange command palette and introduce the KListWithOverflow component to add responsive design.

Screenshots (if applicable)

Compartir.pantalla.-.2024-02-29.12_18_35.mp4

Reviewer guidance

How can a reviewer test these changes?

  1. Go and edit the nodes of a channel
  2. Select multiple topics and resources
  3. Resize your screen and see that everything is displaying ok

References

Closes #3423.

Added @vue/composition-api

Comments

Vue composition api was added to support the new KDS component and to allow the usage of composition api in studio in the future. I have tested studio on several places and didnt find anything wrong with it.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl force-pushed the update-command-palette branch from 0a494ed to 9c80359 Compare February 27, 2024 21:13
@AlexVelezLl AlexVelezLl marked this pull request as ready for review February 27, 2024 21:17
@AlexVelezLl AlexVelezLl force-pushed the update-command-palette branch from e37d7d5 to f1924c2 Compare February 29, 2024 17:16
@AlexVelezLl AlexVelezLl requested a review from akolson February 29, 2024 17:22
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct to me, nothing rings a bell. Great work @AlexVelezLl!

@AlexVelezLl
Copy link
Member Author

Thanks @akolson! Will merge this to prepare the feature branch for QA, and after we can update to the latest KDS released version.

@AlexVelezLl AlexVelezLl merged commit c7966a6 into learningequality:studio-usability-enhancements Feb 29, 2024
13 checks passed
@AlexVelezLl AlexVelezLl deleted the update-command-palette branch February 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants