Update KListWithOverflow

learningequality · Feb 27, 2024 · 0a494ed · 0a494ed
1 parent 3bfdb1e
commit 0a494ed
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue b/contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
@@ -96,6 +96,7 @@
               <template #menu>
                 <KDropdownMenu
                   :options="overflowItems"
+                  @select="(option) => option.onClick()"
                 />
               </template>
             </KIconButton>
@@ -382,7 +383,7 @@
             {
               label: this.$tr('editLanguageButton'),
               icon: 'language',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.LANGUAGE),
+              onClick: this.quickEditModalFactory(QuickEditModals.LANGUAGE),
               condition: this.canEdit,
               dataTest: 'change-langugage-btn',
             },
@@ -391,21 +392,21 @@
             {
               label: this.$tr('editCategoriesButton'),
               icon: 'categories',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.CATEGORIES),
+              onClick: this.quickEditModalFactory(QuickEditModals.CATEGORIES),
               condition: this.canEdit,
               dataTest: 'change-categories-btn',
             },
             {
               label: this.$tr('editLevelsButton'),
               icon: 'levels',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.LEVELS),
+              onClick: this.quickEditModalFactory(QuickEditModals.LEVELS),
               condition: this.canEdit,
               dataTest: 'change-levels-btn',
             },
             {
               label: this.$tr('editLearningActivitiesButton'),
               icon: 'activities',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.LEARNING_ACTIVITIES),
+              onClick: this.quickEditModalFactory(QuickEditModals.LEARNING_ACTIVITIES),
               condition: this.canEdit,
               disabled: this.isTopicSelected,
               dataTest: 'change-learning-activities-btn',
@@ -415,23 +416,23 @@
             {
               label: this.$tr('editSourceButton'),
               icon: 'attribution',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.SOURCE),
+              onClick: this.quickEditModalFactory(QuickEditModals.SOURCE),
               condition: this.canEdit,
               disabled: this.isTopicSelected,
               dataTest: 'change-learning-activities-btn',
             },
             {
               label: this.$tr('editAudienceButton'),
               icon: 'audience',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.AUDIENCE),
+              onClick: this.quickEditModalFactory(QuickEditModals.AUDIENCE),
               condition: this.canEdit,
               disabled: this.isTopicSelected,
               dataTest: 'change-audience-btn',
             },
             {
               label: this.$tr('editWhatIsNeededButton'),
               icon: 'lesson',
-              onClick: () => this.quickEditModalFactory(QuickEditModals.WHAT_IS_NEEDED),
+              onClick: this.quickEditModalFactory(QuickEditModals.WHAT_IS_NEEDED),
               condition: this.canEdit,
               dataTest: 'change-resources-neded-btn',
             },

diff --git a/contentcuration/contentcuration/frontend/shared/app.js b/contentcuration/contentcuration/frontend/shared/app.js
@@ -106,6 +106,7 @@ import {
 } from 'vuetify/lib/directives';
 import VueIntl from 'vue-intl';
 import Croppa from 'vue-croppa';
+import VueCompositionApi from '@vue/composition-api';
 import { Workbox, messageSW } from 'workbox-window';
 import KThemePlugin from 'kolibri-design-system/lib/KThemePlugin';
 import trackInputModality from 'kolibri-design-system/lib/styles/trackInputModality';
@@ -158,6 +159,7 @@ if (process.env.NODE_ENV !== 'production') {
 Vue.use(Croppa);
 Vue.use(VueIntl);
 Vue.use(VueRouter);
+Vue.use(VueCompositionApi);
 Vue.use(Vuetify, {
   components: {
     // Explicitly register used Vuetify components globally

diff --git a/package.json b/package.json
@@ -56,6 +56,7 @@
   "dependencies": {
     "@sentry/vue": "^7.11.1",
     "@toast-ui/editor": "^2.3.1",
+    "@vue/composition-api": "^1.7.2",
     "ajv": "^8.12.0",
     "axios": "^1.6.2",
     "broadcast-channel": "^5.1.0",
@@ -72,7 +73,7 @@
     "jspdf": "https://github.com/parallax/jsPDF.git#b7a1d8239c596292ce86dafa77f05987bcfa2e6e",
     "jszip": "^3.10.1",
     "kolibri-constants": "^0.2.0",
-    "kolibri-design-system": "https://github.com/AlexVelezLl/kolibri-design-system#5d39375ed20e4e86d397c94a2176219668186370",
+    "kolibri-design-system": "https://github.com/AlexVelezLl/kolibri-design-system#7971ea4b49b7f1c817d80aaa01286e630801d3c2",
     "lodash": "^4.17.21",
     "material-icons": "0.3.1",
     "mutex-js": "^1.1.5",

diff --git a/yarn.lock b/yarn.lock
@@ -9116,9 +9116,9 @@ kolibri-constants@^0.2.0:
   resolved "https://registry.yarnpkg.com/kolibri-constants/-/kolibri-constants-0.2.0.tgz#47c9d773894e23251ba5ac4db420822e45603142"
   integrity sha512-WYDMGDzB9gNxRbpX1O2cGe1HrJvLvSZGwMuAv6dqrxJgPf7iO+Hi40/1CXjHM7nk5CRt+hn5bqnMzCBmj1omPA==
 
-"kolibri-design-system@https://github.com/AlexVelezLl/kolibri-design-system#5d39375ed20e4e86d397c94a2176219668186370":
+"kolibri-design-system@https://github.com/AlexVelezLl/kolibri-design-system#086b5c3f1f109234d1ad4b521651fbc88f04c54c":
   version "3.0.1"
-  resolved "https://github.com/AlexVelezLl/kolibri-design-system#5d39375ed20e4e86d397c94a2176219668186370"
+  resolved "https://github.com/AlexVelezLl/kolibri-design-system#086b5c3f1f109234d1ad4b521651fbc88f04c54c"
   dependencies:
     "@vue/composition-api" "^1.7.2"
     aphrodite "https://github.com/learningequality/aphrodite/"