Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Command Palette" for editing multiple resources #3423

Closed
9 tasks done
marcellamaki opened this issue Jun 10, 2022 · 2 comments
Closed
9 tasks done

Implement "Command Palette" for editing multiple resources #3423

marcellamaki opened this issue Jun 10, 2022 · 2 comments

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Jun 10, 2022

This issue is part of the Studio Usability Enhancement work. The scope of this issue is to create a top bar of icons (the "command palette") for use in quick editing multiple resources.

Scope

  • Create a mobile-responsive top bar using <KIconButton/>s
  • Conditionally displaying the number of icons, based on screen size
  • Top bar should only appear when at least one resource has been selected for edit using the checkbox selection
  • Icons for edit functions that are not available should be disabled
  • Button clicks should be set up to emit events that the corresponding form will be listening for

Out of scope

  • Implementing the forms that correspond to each edit
  • Adding the icons to KDS

Specs

IMPORTANT: Please review the figma specs related to responsive design guidance for full details

Reference guidelines for tooltips, icon names, and interactivity
Screen Shot 2022-06-13 at 8.26.55 AM.png

Screen Shot 2022-06-13 at 8.28.58 AM.png
Screen Shot 2022-06-13 at 8.29.11 AM.png
Screen Shot 2022-06-13 at 8.29.24 AM.png

Screen Shot 2022-06-13 at 8.32.42 AM.png
Screen Shot 2022-06-13 at 8.32.48 AM.png

Acceptance Criteria

  • Layout should match Figma specifications, including mobile layout
  • Correct enabling and disabling of icon buttons on: selecting resources, selecting folders, selecting both
  • Each button emits an event on click that can be used by the corresponding form
  • KIconButtons and command palette are keyboard navigable, and have the correct labelling for screen reader users
@manavagr1108
Copy link
Contributor

Hey @marcellamaki, I find this issue intresting. Can I take up this issue?

@AlexVelezLl
Copy link
Member

Implemented in #4446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants