Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release 2022-12-02 #3864

Merged
merged 32 commits into from
Dec 7, 2022
Merged

Patch release 2022-12-02 #3864

merged 32 commits into from
Dec 7, 2022

Conversation

bjester
Copy link
Member

@bjester bjester commented Dec 2, 2022 •
edited
Loading

Summary

This is a patch release to further address:

  • Issues deleting images from exercise fields
  • Issue with syncing imported exercises
  • Handling errors during file upload
  • Inaccurate publishing progress percentage
  • Clarification and reduction of error reports
Issue PR Category QA Focus
#3817 #3837, #3870 Bug fix Remove uploaded image from exercise markdown
#3112 #3859 Bug fix Sync assessment items for a channel with imported content
#3795 #3855 Bug fix View channel info modal while publishing
#3856 #3855, #3866 SysOps / Bug fix Critical workflows that interact with backend
#3845 #3855 Bug fix Activate a staged/cheffed channel
#3860 #3855 Bug fix Error handling during file upload (attempt to encounter a file upload error)
N/A #3852 SysOps / Bug fix Upload files as an admin
#3827 #3855 SysOps N/A
#3857 #3855 SysOps N/A
#3828 #3855 SysOps N/A

rtibbles and others added 26 commits November 22, 2022 14:27
@rtibbles
Remove image from innerHTML on remove.
60080d6
@rtibbles
Create remove event mechanism for clearing custom span element.
01b4503
@rtibbles
Consolidate all blank space wrapping in custom markdown field logic.
02216e9
@rtibbles
Clean up squire keydown handling.
d5b981e
@rtibbles
Modify prop values using web component interface rather than
ff87c48 
trying to do prohibited direct prop modification on component.
Lint.
@rtibbles
Add extra edge case handling for sibling checking.
f1f0a5c
@rtibbles
Tweak markdown conversion to prevent addition of excess line breaks.
48a97be
@bjester
Merge pull request #3837 from rtibbles/assessment_images
7f7e675 
Make the image remove option work
@bjester
Only enqueue storage calculation task for non-admins
b6e08ba
@bjester
Add helpers to celery app class for production intervention
d2d1921
@bjester
Add calculation delay to ricecooker bulk endpoint, update tests
94ae2ac
@bjester
Reorganize task revocation logic
a997d0c
@bjester
Add management command that reconciles tasks for changes
a331538
@rtibbles
Merge pull request #3852 from bjester/angry-tasks
9d84374 
Add task helpers and stop enqueuing storage calculation tasks for admins
@vkWeb
Fixes sync_channel assessment_item bug
f0986c7
@bjester
[#3827][#3828] Add probers for alerting to task and change abnormalities
bafe68c
@bjester
[#3795] Retain TASK_ID and COPYING_FLAG when fetching from the server
5345841
@bjester
[#3856][#3857] Update axios, silence aborted connection errors, and o…
cfbfe3d 
…ther sentry reporting changes
@bjester
[#3845] Defensive check against double submit on channel activation
f16e24f
@bjester
[#3845] Disalbing of channel activation submit button while processing
a86e0a3
@bjester
[#3860] Refactor file upload handling, making return values consisten…
fe66038 
…t and better error handling
@bjester
[#3856] Add axios to include it for transform in jest
b714641
@bjester
[#3860] Defensive check on file duration, which might occur when file…
8bee2fd 
… upload fails
@bjester
Merge pull request #3855 from bjester/mo-patches
706d7d6 
Hotfixes to add new probers, address Sentry reporting issues, and other issues
@bjester
Merge pull request #3859 from vkWeb/fix/sync_channel_assessment_item
b63e0a3 
Fixes `sync_channel` assessment item bug
@bjester
Merge branch 'master' into hotfixes
28398d8
@bjester bjester marked this pull request as ready for review December 2, 2022 18:43
bjester and others added 3 commits December 5, 2022 07:40
@bjester
Fix axios key name for custom param serializer
ef66578
@bjester
Merge pull request #3866 from bjester/fix-axios-serializer
7517281 
Fix axios key name for custom param serializer
@rtibbles
Revert change that did markdown conversion last to avoid escaped mark…
b310b20 
…down.

Add regression test to make guarantee about markdown conversion.
radinamatic
radinamatic approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go!!! 👍🏽 💯 :shipit:

rtibbles
rtibbles approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this message.

@bjester bjester merged commit 7e3a110 into master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjester @radinamatic @rtibbles @vkWeb