Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove image from exercise question or answer #3817

Closed
bjester opened this issue Nov 15, 2022 · 5 comments
Closed

Unable to remove image from exercise question or answer #3817

bjester opened this issue Nov 15, 2022 · 5 comments
Assignees
Labels

Comments

@bjester
Copy link
Member

bjester commented Nov 15, 2022

Observed behavior

Images removed from question or answer descriptions reappear after the user's next interaction

  1. Open a channel for editing
  2. Create or edit an exercise, and navigate to the Questions tab
  3. Click the pencil icon to edit a question
  4. Click the pencil icon to edit the question's description
  5. Upload an image to the question description
  6. After finalizing the image upload, click the meatball menu that appears on hovering over the image and select 'Remove'
  7. Click NEW ANSWER
  8. Observe the removed image reappears

Expected behavior

Images removed from exercise questions or answers should not reappear once removed

User-facing consequences

Inability to revise or edit exercises when images need to be removed

Errors and logs

No errors

Additional information

https://learningequality.slack.com/archives/C0LK8QS9J/p1668546749620759

Usage Details

  • Browser: Firefox or Chrome
@bjester bjester added P0 - critical Priority: Release blocker or regression DEV: frontend TAG: regression labels Nov 15, 2022
@rtibbles
Copy link
Member

I suspect this may be to do with the monolithic way that assessment data is saved to the backend?

@rtibbles rtibbles self-assigned this Nov 22, 2022
@rtibbles
Copy link
Member

OK, this seems to be more limited in scope than I had initially feared. This seems to only happen when using the context menu on the image to remove it, if you simply put the cursor next to the image and input backspace, the image does get properly removed.

@bjester
Copy link
Member Author

bjester commented Nov 22, 2022

Oh thank goodness

@rtibbles
Copy link
Member

rtibbles commented Nov 22, 2022

Oddly, the resize and edit options from the same context menu seem to get properly applied, so it is very isolated.

@bjester bjester added P1 - important Priority: High impact on UX and removed P0 - critical Priority: Release blocker or regression labels Nov 22, 2022
@rtibbles
Copy link
Member

Fixed in #3837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants