-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Topics page header navigation #8894
Update Topics page header navigation #8894
Conversation
import HeaderTabs from '../../../../coach/assets/src/views/common/HeaderTabs'; | ||
import HeaderTab from '../../../../coach/assets/src/views/common/HeaderTabs/HeaderTab'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad this was a straight-forward drop-in replacement!
Preferably we'd move this to core API spec (to avoid cross-plugin references) or even KDS (to make this component fully documented and reusable across products)
I'll let you and @rtibbles decide whether that should happen now or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to vote for later. Thanks to our updated string machinery, cross plugin imports like this are less of a concern, but the long import paths are not great.
Also good to think about the contrast between code used in common between apps vs things we want to expose as a common API.
I think most of our core API spec is the former at the moment, whereas it should be exclusively the latter.
578d93d
to
979d464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement, nice job!
The only thing I'm noticing (aside from #8627) is that the header tabs behave a little strangely. At smaller sizes the 'Search' tab launches the side panel which seems incorrect:
The tabs also initially start out with neither selected:
I'm happy to open a follow-up issue for this if you'd like
I think there's a related issue here: #8847 |
updated that issue |
Summary
<HeaderTabs />
usageReferences
Fixes #8630
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)