-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues with library top-nav #8630
Comments
@jtamiace -- I will likely start working on this tomorrow, but just want to get a 👍 / 👎 on the items that Devon notes so I know which feedback I should move forward with. If you have a chance today to leave some comments, that would be really helpful! Thanks! |
let me know if you'd like me to break any items out into independent issues so they can be deprioritized |
Everything is a 👍🏼 except
This was intentional. I was hoping that the breadcrumb + thumb would be enough to avoid duplicating the current folder title and take up a lot of screen space with a large header. |
if the breadcrumb alignment issue turns out to be KDS-specific, recommend opening a separate issue there |
KDS issue for breadcrumb alignment here: learningequality/kolibri-design-system#284 |
removed from issue description |
Observed behavior
The top-nav of the library is not styled consistently with existing analogous navigation in Coach. In particular:
A few more observed issues:
Expected behavior
User-facing consequences
Steps to reproduce
Context
0.15.0-beta1
The text was updated successfully, but these errors were encountered: