Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with library top-nav #8630

Closed
indirectlylit opened this issue Nov 7, 2021 · 6 comments · Fixed by #8894
Closed

issues with library top-nav #8630

indirectlylit opened this issue Nov 7, 2021 · 6 comments · Fixed by #8894
Assignees
Labels
DEV: frontend P1 - important Priority: High impact on UX
Milestone

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Nov 7, 2021

Observed behavior

The top-nav of the library is not styled consistently with existing analogous navigation in Coach. In particular:

  • purple bottom-bar styling has rounded radius
  • 'UPPER CASE' vs 'Sentence case'
  • non-enabled text color
  • hover states
  • spacing
coach learn
2021-11-07 18 16 10 2021-11-07 18 18 40

A few more observed issues:

issue screenshot
nav overlapping with other content 2021-11-07 18 24 28
shifting hover state 2021-11-07 18 25 10
missing header and description on smaller screens 2021-11-07 18 28 36
icon can overlap tabs (note: in some languages text could be much longer) 2021-11-07 18 34 18

Expected behavior

  • consistent styling with coach tabs
  • grid-based layout to prevent broken layouts
  • responsively handle both small window sizes and long label text lengths
  • Important information such as the main header and description should not completely disappear because window got smaller

User-facing consequences

  • Users may struggle to navigate properly on small windows
  • Inconsistent styling with other parts of app
  • Users of smaller screens lack critical information

Steps to reproduce

  • Compare to Coach
  • Try with longer label text
  • Try with smaller window sizes

Context

0.15.0-beta1

@indirectlylit indirectlylit added this to the 0.15.0 milestone Nov 7, 2021
@indirectlylit indirectlylit added P1 - important Priority: High impact on UX DEV: frontend labels Nov 11, 2021
@marcellamaki
Copy link
Member

@jtamiace -- I will likely start working on this tomorrow, but just want to get a 👍 / 👎 on the items that Devon notes so I know which feedback I should move forward with. If you have a chance today to leave some comments, that would be really helpful! Thanks!

@indirectlylit
Copy link
Contributor Author

let me know if you'd like me to break any items out into independent issues so they can be deprioritized

@jtamiace
Copy link
Member

Everything is a 👍🏼 except

missing header and description on smaller screens

This was intentional. I was hoping that the breadcrumb + thumb would be enough to avoid duplicating the current folder title and take up a lot of screen space with a large header.

@indirectlylit
Copy link
Contributor Author

if the breadcrumb alignment issue turns out to be KDS-specific, recommend opening a separate issue there

@marcellamaki
Copy link
Member

KDS issue for breadcrumb alignment here: learningequality/kolibri-design-system#284

@indirectlylit
Copy link
Contributor Author

KDS issue for breadcrumb alignment here: learningequality/kolibri-design-system#284

removed from issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants