Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs are misaligned: links vs. text #284

Closed
marcellamaki opened this issue Dec 10, 2021 · 0 comments · Fixed by #292
Closed

Breadcrumbs are misaligned: links vs. text #284

marcellamaki opened this issue Dec 10, 2021 · 0 comments · Fixed by #292
Assignees
@MisRob
Labels
category: library Shared code library type: issue Something isn't working

Comments

@marcellamaki
Copy link
Member

Product

KDS/Kolibri

Expected behavior

Text should be aligned in the breadcrumbs

Actual behavior

Bottom alignment is the bottom of the underline under breadcrumbs that are a link, rather than the text of the link itself

Steps to reproduce the issue

View Breadcrumbs in topics page of kolibri

Additional information

image

Originally reported in: learningequality/kolibri#8630
@marcellamaki marcellamaki mentioned this issue Dec 10, 2021
Closed
@MisRob MisRob self-assigned this Dec 22, 2021
@MisRob MisRob added category: library Shared code library type: issue Something isn't working labels Dec 22, 2021
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 27, 2021
@MisRob
Consolidate breadcrumbs alignment
b591fc2 
Fixes learningequality#284
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 29, 2021
@MisRob
Consolidate breadcrumbs alignment
cb25288 
Fixes learningequality#284
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 29, 2021
@MisRob
Consolidate breadcrumbs alignment
d4b4225 
Fixes learningequality#284
@MisRob MisRob mentioned this issue Dec 31, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MisRob MisRob

Labels
category: library Shared code library type: issue Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A new documentation page and layout fixes for KBreadcrumbs MisRob/kolibri-design-system
2 participants
@MisRob @marcellamaki