Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel navigation header tears away from side nav #8627

Closed
indirectlylit opened this issue Nov 7, 2021 · 2 comments
Closed

channel navigation header tears away from side nav #8627

indirectlylit opened this issue Nov 7, 2021 · 2 comments
Assignees
Labels
P1 - important Priority: High impact on UX
Milestone

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

at some browser sizes the header tears away from the side-nav:

2021-11-07 15 29 26

Expected behavior

I would expect the side nav to continue scrolling up to the top when the header disappears

User-facing consequences

slightly broken-looking layout

Steps to reproduce

set browser width to ~750 px and view resources in library browser

Context

v0.15.0-beta1

@indirectlylit indirectlylit added this to the 0.15.0 milestone Nov 7, 2021
@indirectlylit
Copy link
Contributor Author

@marcellamaki FYI this behavior is improved in your PR #8637

2021-11-11 18 05 54

@marcellamaki marcellamaki added the P1 - important Priority: High impact on UX label Nov 15, 2021
@MisRob MisRob assigned MisRob and unassigned marcellamaki Dec 3, 2021
MisRob added a commit to MisRob/kolibri that referenced this issue Dec 16, 2021
MisRob added a commit to MisRob/kolibri that referenced this issue Dec 16, 2021
MisRob added a commit to MisRob/kolibri that referenced this issue Dec 17, 2021
MisRob added a commit to MisRob/kolibri that referenced this issue Dec 17, 2021
MisRob added a commit to MisRob/kolibri that referenced this issue Dec 17, 2021
@MisRob
Copy link
Member

MisRob commented Dec 17, 2021

This was related to issues caused by certain layout of elements within one breakpoint. The layout seems to haven been updated recently and I can't find conditions to reproduce this particular issue anymore. I made some improvements in #8947 that were meant as a fix for this issue originally, but even without them things seems to work pretty well now to me, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

3 participants