-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design updates #8637
Design updates #8637
Conversation
For sure! |
Hi @marcellamaki I was just wondering are all the items listed with checkboxes ready for testing? Just let me know if so, thanks! :) |
Hi @pcenov - thank you for your question! Apologies for not actually indicating which are ready to test. Everything that is checked now is ready for review, and I've updated the question about the links. Thank you for your careful eye on everything! So appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and manual QA checks out.
@marcellamaki I tested the following points and things are looking much better, did not uncover any new issues:
Library page
Classes page
Search panel
|
Summary
Addresses many design related updates in #8563 to-dos and comments
Topics Page
Library page
Classes page
Search panel
Cards
Feedback from @pcenov
Feedback from @jtamiace
For the purpose of keeping things moving and not making giant PRs, there are a few additional updates, including on card layout, bookmarks, and the search side panel that will be addressed in separately.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)