Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with info panel freezing, not closing #8611

Closed
marcellamaki opened this issue Nov 5, 2021 · 4 comments · Fixed by #8664
Closed

Fix issue with info panel freezing, not closing #8611

marcellamaki opened this issue Nov 5, 2021 · 4 comments · Fixed by #8664
Assignees
Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

Reported by @bjester and @jtamiace during bug bash

Clicking the info icon on a resource in the Library tab opens a side panel with information, but there's no way to close it as the "X" does not function and clicking outside doesn't close it either. Tab CPU consumption hits 100% and stops responding

Kolibri froze and crashed after opening information panel while browsing a channel. Repeatable

@marcellamaki marcellamaki added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression labels Nov 5, 2021
@nucleogenesis nucleogenesis self-assigned this Nov 9, 2021
@marcellamaki marcellamaki mentioned this issue Nov 9, 2021
23 tasks
@marcellamaki
Copy link
Member Author

See also #8594

@nucleogenesis
Copy link
Member

nucleogenesis commented Nov 10, 2021

@jtamiace @bjester

What channels/contents were you viewing when you encountered the error?

Would you be able to replicate and try to salvage a screenshot of any console errors that might be coming up? I've tried to replicate with many types of contents in several channels but not once have I had any issue with either of:

  • 100% CPU infinite loop / memory leak situation
  • Being unable to close the side panel

I tried Fedora & Ubuntu & iOS Chromes but could not replicate.

Perhaps there is some quirk of how a channel is set - or perhaps I need to try again with more cross-channel shared contents? In any case, whatever content you replicate with will hopefully do the same on my end.

@pcenov
Copy link
Member

pcenov commented Nov 10, 2021

Hi @nucleogenesis, I can replicate this issue in the latest 0.15 build by going to the Library page, selecting any of the available channels such as Sikana and then clicking the View Information icon on any of the resources displayed within the Browse channel view:

2021-11-10_13-28-09

Note that I'm currently not seeing any errors for that in the browser console.
However when I initially reported that issue here: #8563 (comment) the error was: TypeError: Cannot read properties of undefined (reading ‘id’)

2021-11-02_16-12-46

cc @radinamatic

@bjester
Copy link
Member

bjester commented Nov 10, 2021

@nucleogenesis It appears this happens specifically when browsing a channel. Here are steps to reproduce:

  1. Open Chrome's task manager
  2. Sign in as a learner
  3. Click the Library tab
  4. Browse a channel on the device
  5. Click the info icon on a resource
  6. See the tab consuming 100% of CPU once open
  7. Cannot close the info side panel

I ran profiling when this happened. It seems it's stuck in a re-render loop
Profile-20211110T075913.json.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants