Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Panel freezing fix #8664

Conversation

nucleogenesis
Copy link
Member

Summary

Vue rerenders when its data changes - so you cannot use splice on anything (or its children) that would cause a rerender because it will constantly be changing itself forever and ever.

Much gratitude to @indirectlylit for the help working this out!

Now the side panel only consumes it's proper allotment of CPU.

References

Fixes #8611

Reviewer guidance

  1. Go to Library page
  2. Go to a Channel where you know a piece of content lives in two places in that same channel (try early math KA-en or something)
  3. Click the (i) on the card when browsing that channel.
  4. See a list of topic names as links at the bottom of the side panel which link you to the same content in a different folder (but NOT one to the currently viewed folder).
  5. Also nothing freezes and everything goes perfectly yayyyy (if you're running in dev mode, check the console error log to see if anything complains about an infinite loop).

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Nov 11, 2021
@nucleogenesis nucleogenesis added this to the 0.15.0 milestone Nov 11, 2021
@rtibbles rtibbles merged commit 0b020e0 into learningequality:release-v0.15.x Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with info panel freezing, not closing
2 participants