Sticky side navigation improvements #8947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairina
approved these changes
Dec 17, 2021
| } else { | ||
| this.stickyTop = '64px'; | ||
| } | ||
| const header = this.$refs.header; |
There was a problem hiding this comment.
What is the difference between using the header ref above as compared to the original: let header = document.getElementsByClassName('header')[0]?
There was a problem hiding this comment.
let header = document.getElementsByClassName('header')[0] seems like a riskier reference, as it could pick up a header class from anywhere in the DOM, whereas this will get the header specifically in this component.
There was a problem hiding this comment.
(also let is unnecessary unless we are intending to reassign the header variable later)
There was a problem hiding this comment.
Yes, I made those changes to make things a bit safer in that regards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was originally fix for #8627. However, it seem that due to recent changes, behavior of the whole page is now different in regards to what is displayed at certain breakpoints and the problematic constellation of elements might be gone for now. or I wasn't able to find new conditions to reproduce it. However, I thought it might be good to submit the work, since it accounts for more scenarios in regards to hidden/visible top bar and also helped with jumping side navigation due to previously frequent styles updates.
Reviewer guidance
Go to Library, select a channel, and scroll the page - it should scroll at first but as soon as the header is not visible, the side navigation should stick to the top of the page so that it's whole area is visible. It shouldn't get stuck or jump. Please test for more screen resolutions.
Testing checklist
PR process
Reviewer checklist
yarnandpip)