-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource discovery: Implement channel card #12607
Resource discovery: Implement channel card #12607
Conversation
Build Artifacts
|
kolibri/plugins/learn/assets/src/views/LibraryPage/AccessibleChannelCard.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/views/LibraryPage/AccessibleChannelCard.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/views/LibraryPage/AccessibleChannelCard.vue
Outdated
Show resolved
Hide resolved
@AllanOXDi please let me know when this is ready for final review. I was just going through all card work so I left some notes here already for important changes. However, I think after that's done, there won't be much else here, perhaps some minor details. Nice work overall. |
6c4e807
to
7f36854
Compare
c9dcad2
to
18deedc
Compare
@MisRob would you mind giving this another look? |
Hi @AllanOXDi, yes - would you please clean up temporary code? As I've already seen this before, I think I will only do a final pre-merge review when everything's ready. Thanks for preparing everything for easier testing :) |
Done! |
dc8f114
to
b5f09da
Compare
Hey @AllanOXDi! I just merged #12717 which had some KCard breaking changes. Could you please rebase the branch, and update the |
4c994a2
to
ed97b8a
Compare
packages/kolibri-common/components/Cards/AccessibleChannelCard.vue
Outdated
Show resolved
Hide resolved
packages/kolibri-common/components/Cards/AccessibleChannelCard.vue
Outdated
Show resolved
Hide resolved
Two last things, @AllanOXDi, and then can be merged :) |
dbd1ded
to
451b857
Compare
7d2974c
to
451b857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AllanOXDi
Summary
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)