Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade places utilizing KCard from beta to its final API #12688

Closed
Tracked by #11888
MisRob opened this issue Oct 1, 2024 · 1 comment
Closed
Tracked by #11888

Upgrade places utilizing KCard from beta to its final API #12688

MisRob opened this issue Oct 1, 2024 · 1 comment

Comments

@MisRob
Copy link
Member

MisRob commented Oct 1, 2024

Dependencies

KDS v5.0.0-rc7

Summary

KDS v5.0.0-rc7 will introduce breaking changes to KCard, such as renaming some props (see release notes as soon as available). In Kolibri, we need to update the following components accordingly:

Furthemore, KDS v5.0.0-rc7 introduces many new guidelines to the KCard documentation page. The components above should be reviewed against it and updated to follow them whenever relevant.

As of Oct 1, 2024, KCardGrid isn't yet used in Kolibri, however if its beta version find its way to Kolibri codebase before this issue is resolved, it should too be updated to its final version and revisited against guidelines - simply follow the KCardGrid documentation page.

@MisRob MisRob changed the title Upgrade places utilizing KCard's from beta to its final API Upgrade places utilizing KCard from beta to its final API Oct 1, 2024
@marcellamaki
Copy link
Member

This has been resolved between Allan's updates/rebasing of his open PRs for the accessible cards, plus other work making use of these cards with the card grid, and no longer needs to be tracked as a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants