Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kds rc7 #12717

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

marcellamaki
Copy link
Member

Summary

  • Updates to kds 5.0.0-rc7
  • Resolves breaking changes to KResponsiveElementMixin and KCard props

Reviewer guidance

  1. Does everything still build without errors in the terminal or console?
  2. Do all tests still pass?
  3. Are there any instances of KResponsiveElementMixin that have not been replaced, or places where KCard has props that still need to be updated?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. DEV: frontend labels Oct 11, 2024
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marcellamaki! This LGTM! I havent found uses of KResponsiveElementMixin nor any of the properties it exposes. And all KCard instances have been updated accordingly. Thanks!

@AlexVelezLl AlexVelezLl merged commit 264bc0b into learningequality:develop Oct 14, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants