Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z-index to fix display of HybridLearningFooter dropdown menu #11399

Conversation

LianaHarris360
Copy link
Member

Summary

  • Updates the CoreMenu styling within the HybridLearningFooter component to include z-index: 7 so that the menu displays on top of other cards, instead of behind.

Before:
Screenshot 2023-10-12 at 2 59 59 PM

After:
Screenshot 2023-10-12 at 2 18 23 PM

References

Fixes #11378
The functionality of the 'Remove from my library' option is fixed in PR #11397

Reviewer guidance

  1. Go to Explore libraries and click the download icon on a card.
  2. Observe the position of 'Remove from my library'.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Oct 12, 2023
@LianaHarris360 LianaHarris360 marked this pull request as ready for review October 12, 2023 20:12
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me - not sure how else we would achieve this except with the z-index tweak!

@rtibbles rtibbles requested a review from pcenov October 12, 2023 20:33
@rtibbles
Copy link
Member

@pcenov when testing this, note that this PR fixes the proper display of the button, but not its functionality - that is fixed in #11397 as @LianaHarris360 notes.

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - implemented as specified! Will further test some scenarios once #11397 is finalized and merged.

@rtibbles rtibbles merged commit 350266b into learningequality:release-v0.16.x Oct 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore libraries - The option 'Remove from my library' is not positioned correctly and not working
3 participants