Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore libraries - The option 'Remove from my library' is not positioned correctly and not working #11378

Closed
pcenov opened this issue Oct 10, 2023 · 3 comments · Fixed by #11399 or #11397
Closed

Explore libraries - The option 'Remove from my library' is not positioned correctly and not working #11378

pcenov opened this issue Oct 10, 2023 · 3 comments · Fixed by #11399 or #11397
Assignees
@LianaHarris360
Labels
P0 - critical Priority: Release blocker or regression
Milestone
Kolibri 0.16.0: B...

Comments

@pcenov
Copy link
Member

pcenov commented Oct 10, 2023

Observed behavior

The option 'Remove from my library' is not displayed correctly and not working

Expected behavior

Correctly displayed and fully functioning 'Remove from my library' option

Steps to reproduce the issue

  1. Install the latest build from My downloads updates - polling and UI #11177
  2. Go to Explore libraries and click the download icon on a card.
  3. Observe the position of 'Remove from my library'
  4. Click 'Remove from my library' and go to 'My downloads' to confirm that the resource is actually removed.

More information

2023-10-10_16-48-39.mp4

Usage Details

Kolibri 0.16beta6
Ubuntu - Chrome, Firefox
@pcenov
Copy link
Member Author

pcenov commented Oct 10, 2023

@radinamatic @marcellamaki

@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Oct 10, 2023
@rtibbles
Copy link
Member

First problem is clearly with the z-index of the dropdown menu falling behind the cards.

The second problem has two possibilities:

  • The removal isn't actually happening when accessed from the remote library browsing page
  • It is actually happening but the API endpoint is still returning contentdownload requests that have a current removal

@rtibbles rtibbles mentioned this issue Oct 12, 2023
Merged
9 tasks
@LianaHarris360 LianaHarris360 mentioned this issue Oct 12, 2023
Merged
7 tasks
@rtibbles
Copy link
Member

Reopening until #11397 is confirmed to fix the issue completely and is merged.

@rtibbles rtibbles reopened this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LianaHarris360 LianaHarris360

Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Milestone
Kolibri 0.16.0: Bugs and Regressions
4 participants
@rtibbles @marcellamaki @LianaHarris360 @pcenov