-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selection behaviour on the My Downloads page #11397
Fix selection behaviour on the My Downloads page #11397
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtibbles I confirm that the selection behaviour is fixed now and the option 'Remove from my library' is functioning.
What puzzles me is that now both 'Remove' and 'Remove selected' are not functioning at all:
2023-10-13_11-29-37.mp4
Also when I remove a resource from the library there is no
snackbar 'Resource removed from my library' as specified in Figma:
2023-10-13_11-37-42.mp4
Not terribly confusing - I have clearly messed something up :) Thanks for checking my working. |
992c27f
to
40acc47
Compare
Removal should be working everywhere now, and the snackbar should display when removing a download while browsing a remote library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented as specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, and since this has the Peter stamp of approval, I think we are good to merge. Thanks for the code cleanup and simplification here, @rtibbles :)
Summary
removeDownloadRequest
function to accept a contentnode_id as its only argument (in the process, fixing the latter part of Explore libraries - The option 'Remove from my library' is not positioned correctly and not working #11378)contentnode_id
for the request totrue
to enable easy lookup in thedownloadRequestMap
and to be compatible with the updatedremoveDownloadRequest
functionReferences
Fixes #11389
Fixes #11378 - now that the z-index issue has been fixed by @LianaHarris360
Reviewer guidance
Ensure that all selection behaviour behaves as expected:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)