Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update2 #8532 Remove text truncator #10616

Merged

Conversation

Pursottam6003
Copy link
Contributor

Summary

From the issue #8532

I have updated the TextTruncator with TexTruncatorCss inside the ChannelCard.vue
`

References

I have taken the reference from the previous issue and commits #8532

Reviewer guidance

A reviewer can test those changes by decreasing the width of the window he/she would expect that the title should be up to 2 lines and the description of the resource will be under 4 lines if it exceeds it will truncate with ...

  • After making the changes we can see
    Screenshot from 2023-05-02 13-03-04

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels May 2, 2023
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right change to me - @pcenov @radinamatic can we just quickly confirm there are no regressions here when displaying channel cards on the library page? A check at different screen sizes should be sufficient.

@pcenov
Copy link
Member

pcenov commented May 3, 2023

Nicely implemented, no issues while manually testing this one @radinamatic:

2023-05-03_15-05-38.mp4

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passed, good to go! 💯 :shipit:

@rtibbles rtibbles merged commit 4dad9b4 into learningequality:develop May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants